Todo List

Member vrml_proc::conversion_context::Mergeable::Merge (Mergeable *other)=0

Merge should not throw exception but return Result type identifying the issue occured

Member vrml_proc::conversion_context::VectorConversionContext< T >::Merge (Mergeable *other) override

Merge should not throw exception but return Result type identifying the issue occured.

Move it into seperated .cpp file.

Class vrml_proc::core::utils::Range< T >

Use Rust create() pattern here to make checks that max is not greater than min.

Namespace vrml_proc::math::cgal

Ideally, vrmlproc should be link CGAl at all, and all these types should be defined in togeom. However, because vrmlproc's TransformationMatrix is dependent on CGAl matrix type, this cannot be done until we use diiferent abstraction for matrix.

Struct vrml_proc::math::Quaternion

Values x, y, z and w should be private and getters and setters shouls be made!

Member vrml_proc::traversor::node_descriptor::NodeDescriptor::BindField (const std::string &fieldName, const Type &defaultValue)

defaultValue value will not have to exist as long as now. Currently, it does, and it saves space, becuase for every e.g. Group node, all default values for every such node are in the scene graph the same. That is possible, because the tree is read-only.

Member vrml_proc::traversor::node_descriptor::NodeDescriptor::BindVrmlNode (const std::string &fieldName, const std::unordered_set< std::string > &validNodeHeaders, const vrml_proc::parser::model::VrmlNode &defaultNode)

defaultNode does not make sense here, as default value should be just NULL - or just an empty node

Member vrml_proc::traversor::node_descriptor::NodeView::Builder::SetDefaultValues (const std::map< std::string, FieldType > &fieldTypes, const std::map< std::string, std::optional< std::reference_wrapper< const bool > > > &boolFields, const std::map< std::string, std::optional< std::reference_wrapper< const std::string > > > &stringFields, const std::map< std::string, std::optional< std::reference_wrapper< const vrml_proc::parser::model::float32_t > > > &float32Fields, const std::map< std::string, std::optional< std::reference_wrapper< const int32_t > > > &int32Fields, const std::map< std::string, std::optional< std::reference_wrapper< const vrml_proc::parser::model::Vec2f > > > &vec2fFields, const std::map< std::string, std::optional< std::reference_wrapper< const vrml_proc::parser::model::Vec3f > > > &vec3fFields, const std::map< std::string, std::optional< std::reference_wrapper< const vrml_proc::parser::model::Vec4f > > > &vec4fFields, const std::map< std::string, std::optional< std::reference_wrapper< const vrml_proc::parser::model::Vec2fArray > > > &vec2fArrayFields, const std::map< std::string, std::optional< std::reference_wrapper< const vrml_proc::parser::model::Vec3fArray > > > &vec3fArrayFields, const std::map< std::string, std::optional< std::reference_wrapper< const vrml_proc::parser::model::Int32Array > > > &int32ArrayFields, const std::map< std::string, std::optional< std::reference_wrapper< const vrml_proc::parser::model::VrmlNode > > > &nodeFields, const std::map< std::string, std::optional< std::vector< std::reference_wrapper< const vrml_proc::parser::model::VrmlNode > > > > &nodeArrayFields)

This has to be made differently.